On Sun, 8 Mar 2009, Hans Verkuil wrote:
> The last one fixes an ivtv regression caused by this change:
>
> changeset:   10811:0a0eba8e64d5
> user:        Trent Piepho <xy...@speakeasy.org>
> date:        Tue Mar 03 20:21:02 2009 -0800
> summary:     videodev: only copy needed part of RW ioctl's parameter
>
> The fix is simple: switch on the full ioctl command instead of just the NR
> field.
>
> Thanks to Martin Dauskardt for doing the bisect and tracing the breakage to
> this change.

Switching on the whole ioctl makes the switch statement a lot less
efficient.  I'd rather just put a if (_IOC_TYPE(cmd) != 'V') return 0; in
there.  That should fix the non-v4l2 ioctls, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to