On Mon, Apr 6, 2026 at 5:31 PM Tamir Duberstein <[email protected]> wrote: > > You're welcome! Actually it seems the lint was already improved > upstream, starting with 1.90.0. > > Link: https://github.com/rust-lang/rust-clippy/commit/c0dc3b61 [0]
Indeed, I had the PR linked in https://github.com/Rust-for-Linux/linux/issues/349, and it is nicer, but it would still fire in a case like this patch :( So we could conditionally enable it for Rust >= 1.90.0 now that we have support for that (and allow locally some cases like this one when they pop up), but it is still simpler to just ignore it (especially since it can be quite confusing for other developers to see it triggering). I think we may want to eventually re-enable it when we use no unstable language features. Added: [ In addition, the lint fired without taking into account the features that have been enabled in a crate [2]. While this was improved in Rust 1.90.0 [3], it would still fire in a case like this patch. ] Thanks! Cheers, Miguel
