Jakub Kicinski <[email protected]> writes: > On Tue, 17 Mar 2026 09:33:34 +0100 Björn Töpel wrote: >> static int >> rss_set_prep_indir(struct net_device *dev, struct genl_info *info, >> struct rss_reply_data *data, struct ethtool_rxfh_param *rxfh, >> - bool *reset, bool *mod) >> + bool *reset, bool *mod, u32 *user_sizep) >> { >> struct netlink_ext_ack *extack = info->extack; >> struct nlattr **tb = info->attrs; >> @@ -685,6 +685,7 @@ rss_set_prep_indir(struct net_device *dev, struct >> genl_info *info, >> } >> >> *mod |= memcmp(rxfh->indir, data->indir_table, data->indir_size); >> + *user_sizep = user_size; >> >> return 0; > > Weak preference for return user_size; instead of output arg, 7th, "p"?
Good point! The 7th and p does have a bad smell to it...
