On Tue, 2026-03-17 at 14:54 -0700, Jakub Kicinski wrote: > On Tue, 17 Mar 2026 18:26:10 +0000 Allison Henderson wrote: > > On Tue, 2026-03-17 at 15:41 +0100, Paolo Abeni wrote: > > > On 3/17/26 12:58 AM, Allison Henderson wrote: > > > > diff --git a/tools/testing/selftests/net/rds/config.sh > > > > b/tools/testing/selftests/net/rds/config.sh > > > > index 791c8dbe1095..7cf56ee8882f 100755 > > > > --- a/tools/testing/selftests/net/rds/config.sh > > > > +++ b/tools/testing/selftests/net/rds/config.sh > > > > @@ -24,7 +24,7 @@ while getopts "g" opt; do > > > > esac > > > > done > > > > > > > > -CONF_FILE="tools/testing/selftests/net/config" > > > > +CONF_FILE="tools/testing/selftests/net/rds/config" > > > > > > > > # no modules > > > > scripts/config --file "$CONF_FILE" --disable CONFIG_MODULES > > > > > > This looks wrong?!? The script is going to update the config file which > > > is under git control. You probably want to copy the default config in a > > > tmp file file, edit the latter and add it to .gitignore and EXTRA_CLEAN. > > > > > > The issue looks pre-existent, but since you are touching this part... > > Well spotted. > > > Sure, so config.sh isnt actually called by anything within the self > > tests or testing harness. It more intended to be a stand alone tool > > for when developers want to enable/disable gcov. If you like we can > > adjust the target to a rds/config.local and copy rds/config there. > > > > CONF_FILE="tools/testing/selftests/net/rds/config.local" > > cp tools/testing/selftests/net/rds/config "$CONF_FILE" > > > > Alternately we could simply have the script default to config.local, > > and add a parameter that allows the caller to specify the config > > path. Let me know what you prefer. > > > > I may split off the config.sh changes into a separate patch so that > > Jakub can start using the config though. > > How do you actually use it? > As it is, calling config.sh directly would add RDS configs to tools/testing/selftests/net/config, and passing the -g flag would enable gcov
> Presumably we should be modifying the config > used for build directly not a snippet. > > By default scripts/config will already use .config in current directory > which should be what people would want 99% of the time? > We can add --file to the script to select the config user wants to > change but keep the default of not specifying the file hence .config? That does sound cleaner. I'll drop the --file from the scripts/config calls so it defaults to .config, and add an optional flag to config.sh for anyone who wants to target a different file. Thank you for the reviews! Allison
