> -----Original Message----- > From: Thomas Gleixner [mailto:[email protected]] > Sent: 2015年8月28日 14:11 > To: Wang Shenwei-B38339 > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Huang > Yongcai-B20788 > Subject: Re: [PATCH v2 1/1] irqchip: imx-gpcv2: Simplify the implementation > > On Wed, 26 Aug 2015, Shenwei Wang wrote: > > u32 imx_gpcv2_get_wakeup_source(u32 **sources) { > > - if (!imx_gpcv2_instance) > > + struct gpcv2_irqchip_data *cd; > > + void __iomem *reg; > > + int i; > > + > > + cd = imx_gpcv2_instance; > > + if (!cd) > > return 0; > > > > + for (i = 0; i < IMR_NUM; i++) { > > + reg = cd->gpc_base + cd->cpu2wakeup + i * 4; > > + cd->wakeup_sources[i] = readl_relaxed(reg); > > + } > > + > > if (sources) > > - *sources = imx_gpcv2_instance->wakeup_sources; > > + *sources = cd->wakeup_sources; > > > > return IMR_NUM; > > } > > So once again. As you said before nothing is going to use the case where > source > == NULL, can we please get rid of it?
It will be used to allocate the memory for the predefined values of interrupts for each power Domain. Can we keep it? Thanks, Shenwei > Thanks, > > tglx
