> From: Wang Nan [mailto:[email protected]] > > This patch fixes a bug that, when offset is provided but function is > lost, parse_perf_probe_point() will give a "" string as function name, > so the checking code at the end of parse_perf_probe_point() become useless. > For example: > > # perf probe +0x1234 > Failed to find symbol in kernel > Error: Failed to add events. > > After this patch: > > # perf probe +0x1234 > Semantic error :Offset requires an entry function. > Error: Command Parse Error.
OK, seems sane now :) Acked-by: Masami Hiramatsu <[email protected]> Thanks! > > Signed-off-by: Wang Nan <[email protected]> > Cc: Arnaldo Carvalho de Melo <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Masami Hiramatsu <[email protected]> > Cc: Namhyung Kim <[email protected]> > Cc: Steven Rostedt <[email protected]> > --- > tools/perf/util/probe-event.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 926bcec..eaacb58 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -1194,9 +1194,13 @@ static int parse_perf_probe_point(char *arg, struct > perf_probe_event *pev) > *ptr++ = '\0'; > } > > - tmp = strdup(arg); > - if (tmp == NULL) > - return -ENOMEM; > + if (arg[0] == '\0') > + tmp = NULL; > + else { > + tmp = strdup(arg); > + if (tmp == NULL) > + return -ENOMEM; > + } > > if (file_spec) > pp->file = tmp; > -- > 1.8.3.4
