On Thu, Jul 30, 2015 at 04:35:23PM +0200, Maciej S. Szmigiero wrote: > Instantiate AC'97 CODEC in fsl_ssi driver AC'97 mode. > > Signed-off-by: Maciej Szmigiero <[email protected]> > --- > sound/soc/fsl/fsl_ssi.c | 21 +++++++++++++++++++++ > 1 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c > index 154bcf6..8e5ff5e 100644 > --- a/sound/soc/fsl/fsl_ssi.c > +++ b/sound/soc/fsl/fsl_ssi.c > @@ -1460,6 +1460,27 @@ done: > _fsl_ssi_set_dai_fmt(&pdev->dev, ssi_private, > ssi_private->dai_fmt); > > + if (fsl_ssi_is_ac97(ssi_private)) { > + u32 ssi_idx; > + > + ret = of_property_read_u32(np, "cell-index", &ssi_idx);
This property is not set anywhere in the imx* DTs.
> + if (ret) {
> + dev_err(&pdev->dev, "cannot get SSI index property\n");
> + goto error_sound_card;
> + }
> +
> + ssi_private->pdev =
> + platform_device_register_data(NULL,
> + "ac97-codec", ssi_idx, NULL, 0);
If you really want to create a device at this point you should use
PLATFORM_DEVID_AUTO. I would prefer something where this is created in
DT. On the other side it is a discoverable bus..
Regards,
Markus
> + if (IS_ERR(ssi_private->pdev)) {
> + ret = PTR_ERR(ssi_private->pdev);
> + dev_err(&pdev->dev,
> + "failed to register AC97 codec platform: %d\n",
> + ret);
> + goto error_sound_card;
> + }
> + }
> +
> return 0;
>
> error_sound_card:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature
