On Tue, Jun 30, 2015 at 08:56:17PM -0400, nick wrote: > > > On 2015-06-30 08:50 PM, Jaegeuk Kim wrote: > > Hi, > > > > On Mon, Jun 29, 2015 at 04:07:01PM -0400, Nicholas Krause wrote: > >> This makes the function check_dnode have a return type of bool > >> due to this particular function only ever returning either one > >> or zero as its return value. > >> > >> Signed-off-by: Nicholas Krause <[email protected]> > >> --- > >> fs/f2fs/gc.c | 10 +++++----- > >> 1 file changed, 5 insertions(+), 5 deletions(-) > >> > >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > >> index e1e7361..ebd4c6c 100644 > >> --- a/fs/f2fs/gc.c > >> +++ b/fs/f2fs/gc.c > >> @@ -487,7 +487,7 @@ block_t start_bidx_of_node(unsigned int node_ofs, > >> struct f2fs_inode_info *fi) > >> return bidx * ADDRS_PER_BLOCK + ADDRS_PER_INODE(fi); > >> } > >> > >> -static int check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, > >> +static bool check_dnode(struct f2fs_sb_info *sbi, struct f2fs_summary > >> *sum, > > > > Then, what about bool is_data_alive() ? > > > > Thanks, > > > There is no function of this name in my searching with either lxr or cscope. > Either my tools aren't finding it or the function you are requesting I make > bool has been removed. > Nick
I meant; if you want to change the return type as a bool type, what about changing its function name too? (e.g., is_data_alive()) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
