Comments below ...

On Thu, 2005-08-11 at 09:43 +0000, yangyi wrote:
> +#ifndef CONFIG_CRITICAL_LATENCY_HIST
>       if (!report_latency(delta))
>               goto out;
> +#endif

Why ? This combined with the hunk below is just preempt_threshold ..
Just use preempt_threshold instead of all the ifdefs everywhere .
 
>       ____trace(cpu, TRACE_FN, tr, CALLER_ADDR0, parent_eip, 0, 0, 0);
>       /*
> @@ -1393,11 +1382,13 @@ check_critical_timing(int cpu, struct cp
>       if (tr->critical_sequence != max_sequence || down_trylock(&max_mutex))
>               goto out;
>  
> +#ifndef CONFIG_CRITICAL_LATENCY_HIST
>       if (!preempt_thresh && preempt_max_latency > delta) {
>               printk("bug: updating %016Lx > %016Lx?\n",
>                       preempt_max_latency, delta);
>               printk("  [%016Lx %016Lx %016Lx]\n", T0, T1, T2);
>       }
> +#endif
>  
>       latency = cycles_to_usecs(delta);
>  


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to