On Fri, May 15, 2015 at 02:38:27AM -0700, Srinivas Kandagatla wrote: > Original issue is that the id field in the dai is not same as the id > in dai_driver when dai driver count == 1. This is due to the legacy > dai naming check, which could possibly cause issues if the audio drivers > written in assumption that dai->id would be always equal to > dai_driver->id. > This assumption is true only if the dai driver count is greater than 1, > and false if dai driver count is 1. On Qcom Lpass driver we hit such > issue while adding support to apq8016. > > The code path which falls back to legacy naming for cases where num_dai > == 1 does not check if there is any valid information in the dai_driver. > This patch fixes that by checking if the dai_driver has valid id and > name before falling back to legacy dai naming > Although the drivers can work around this issue by only using > dai->driver->id, but this patch attempts to fix the actual issue. > > Suggested-by: Lars-Peter Clausen <[email protected]> > Signed-off-by: Srinivas Kandagatla <[email protected]> > ---
Acked-by: Kenneth Westfield <[email protected]> -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
