On Fri, Mar 27, 2015 at 04:46:44AM -0700, tip-bot for Denys Vlasenko wrote: > Commit-ID: 146b2b097d7a322b64b88a927fc5d870fc79a60b > Gitweb: http://git.kernel.org/tip/146b2b097d7a322b64b88a927fc5d870fc79a60b > Author: Denys Vlasenko <[email protected]> > AuthorDate: Wed, 25 Mar 2015 18:18:13 +0100 > Committer: Ingo Molnar <[email protected]> > CommitDate: Fri, 27 Mar 2015 09:57:05 +0100 > > x86/asm/entry/64: Use better label name, fix comments > > A named label "ret_from_sys_call" implies that there are jumps > to this location from elsewhere, as happens with many other > labels in this file. > > But this label is used only by the JMP a few insns above. > To make that obvious, use local numeric label instead. > > Improve comments: > > "and return regs->ax" isn't too informative. We always return > regs->ax. > > The comment suggesting that it'd be cool to use rip relative > addressing for CALL is deleted. It's unclear why that would be > an improvement - we aren't striving to use position-independent > code here. PIC code here would require something like LEA > sys_call_table(%rip),reg + CALL *(reg,%rax*8)... > > "iret frame is also incomplete" is no longer true, fix that too. > > Also fix typo in comment. > > Signed-off-by: Denys Vlasenko <[email protected]> > Cc: Alexei Starovoitov <[email protected]> > Cc: Andy Lutomirski <[email protected]> > Cc: Borislav Petkov <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: H. Peter Anvin <[email protected]> > Cc: Kees Cook <[email protected]> > Cc: Linus Torvalds <[email protected]> > Cc: Oleg Nesterov <[email protected]> > Cc: Steven Rostedt <[email protected]> > Cc: Will Drewry <[email protected]> > Link: > http://lkml.kernel.org/r/[email protected] > Signed-off-by: Ingo Molnar <[email protected]> > --- > arch/x86/kernel/entry_64.S | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-)
Shouldn't you take v2 of that one? https://lkml.kernel.org/r/[email protected] v2 is missing this hunk though: --- @@ -1407,7 +1406,7 @@ ENTRY(nmi) * NMI. */ - /* Use %rdx as out temp variable throughout */ + /* Use %rdx as our temp variable throughout */ pushq_cfi %rdx CFI_REL_OFFSET rdx, 0 -- I blame Denys for sending too many patches! :) -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
