Tanya, On Sun, Sep 28, 2014 at 09:37:00AM +0300, Tanya Brokhman wrote: > The need for performing read disturb is determined according to new > statistics collected per eraseblock: > - read counter: incremented at each read operation > reset at each erase > - last erase time stamp: updated at each erase > > This patch adds the infrastructure for the above statistics > > Signed-off-by: Tanya Brokhman <[email protected]> > --- ... > @@ -385,6 +402,38 @@ static ssize_t dev_attribute_show(struct device *dev, > return ret; > } > > +static ssize_t dev_attribute_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + int value; > + struct ubi_device *ubi; > + > + ubi = container_of(dev, struct ubi_device, dev); > + ubi = ubi_get_device(ubi->ubi_num); > + if (!ubi) > + return -ENODEV; > + > + if (kstrtos32(buf, 10, &value)) > + return -EINVAL; > + /* Consider triggering full scan if threshods change */ > + else if (attr == &dev_dt_threshold) { > + if (value < UBI_MAX_DT_THRESHOLD) > + ubi->dt_threshold = value; > + else > + pr_err("Max supported threshold value is %d", > + UBI_MAX_DT_THRESHOLD); > + } else if (attr == &dev_rd_threshold) { > + if (value < UBI_MAX_READCOUNTER) > + ubi->rd_threshold = value; > + else > + pr_err("Max supported threshold value is %d", > + UBI_MAX_READCOUNTER); > + } > + > + return count; > +} > + ...
One small style nit. As per Documentation/CodingStyle [line 169] if one branch in a conditional uses braces then all branches should use braces. -- Jeremiah Mahler [email protected] http://github.com/jmahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
