On Sat, 20 Sep 2014, Pramod Gurav wrote: > These headers are not required hence this change removes them from > the driver. > > Cc: Guennadi Liakhovetski <[email protected]> > Cc: Chris Ball <[email protected]> > Cc: Ulf Hansson <[email protected]> > Cc: [email protected] > Signed-off-by: Pramod Gurav <[email protected]>
NAK. The fact, that code builds without certain headers doesn't mean, they aren't needed. E.g. string.h is needed for memcpy(), scatterlist.h is needed for struct scatterlist etc. Thanks Guennadi > --- > drivers/mmc/host/usdhi6rol0.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c > index f0a39eb..4094d8f 100644 > --- a/drivers/mmc/host/usdhi6rol0.c > +++ b/drivers/mmc/host/usdhi6rol0.c > @@ -12,21 +12,14 @@ > #include <linux/device.h> > #include <linux/dma-mapping.h> > #include <linux/dmaengine.h> > -#include <linux/highmem.h> > #include <linux/interrupt.h> > #include <linux/io.h> > -#include <linux/log2.h> > #include <linux/mmc/host.h> > #include <linux/mmc/mmc.h> > -#include <linux/mmc/sd.h> > #include <linux/mmc/sdio.h> > #include <linux/module.h> > #include <linux/pagemap.h> > #include <linux/platform_device.h> > -#include <linux/scatterlist.h> > -#include <linux/string.h> > -#include <linux/time.h> > -#include <linux/virtio.h> > #include <linux/workqueue.h> > > #define USDHI6_SD_CMD 0x0000 > -- > 1.8.3.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
