On 18 August 2014 15:12, Grégory Soutadé <[email protected]> wrote: > Checks EXT_CSD_PARTITION_SETTING_COMPLETED bit before > computing enhanced user area offset and size, and adding > mmc general purpose partitions. > The two needs EXT_CSD_PARTITION_SETTING_COMPLETED bit be set > to be valid (as described in JEDEC standard). > > Signed-off-by: Grégory Soutadé <[email protected]> > --- > drivers/mmc/core/mmc.c | 167 > +++++++++++++++++++++++++++--------------------- > 1 file changed, 95 insertions(+), 72 deletions(-) > > Changelog v2: > Move code for user area and general purpose partitions > into functions.
Overall I like the end-result of this patch. What I don't like is that you move code and fix bugs in same patch. Could possibly, split this up into two patches? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
