On Tue, Jun 17, 2014 at 08:50:30AM -0700, Greg KH wrote: > On Tue, Jun 17, 2014 at 10:56:04PM +0800, Jeff Liu wrote: > > > > On 06/17/2014 22:42 PM, James Bottomley wrote: > > > On Tue, 2014-06-17 at 22:25 +0800, Jeff Liu wrote: > > >> From: Jie Liu <[email protected]> > > >> > > >> It's better to return the actual error rather than NULL because > > >> kset_register() can failed due to other reasons. > > >> > > >> Cc: Christoph Lameter <[email protected]> > > >> Cc: Greg Kroah-Hartman <[email protected]> > > >> Cc: Andrew Morton <[email protected]> > > >> Cc: Pekka Enberg <[email protected]> > > >> Cc: Matt Mackall <[email protected]> > > >> Cc: Benjamin Herrenschmidt <[email protected]> > > >> Cc: Paul Mackerras <[email protected]> > > >> Cc: Martin Schwidefsky <[email protected]> > > >> Cc: Heiko Carstens <[email protected]> > > >> Cc: Herbert Xu <[email protected]> > > >> Cc: David S. Miller <[email protected]> > > >> Cc: Stefan Richter <[email protected]> > > >> Cc: Joerg Roedel <[email protected]> > > >> Cc: James E.J. Bottomley <[email protected]> > > >> Cc: Helge Deller <[email protected]> > > >> Cc: Bjorn Helgaas <[email protected]> > > >> Cc: Chris Mason <[email protected]> > > >> Cc: Josef Bacik <[email protected]> > > >> Cc: Steven Whitehouse <[email protected]> > > >> Cc: Boaz Harrosh <[email protected]> > > >> Cc: Benny Halevy <[email protected]> > > >> Cc: Christine Caulfield <[email protected]> > > >> Cc: David Teigland <[email protected]> > > >> Cc: Theodore Ts'o <[email protected]> > > >> Cc: Andreas Dilger <[email protected]> > > >> Cc: Jaegeuk Kim <[email protected]> > > >> Cc: Changman Lee <[email protected]> > > >> Cc: Mark Fasheh <[email protected]> > > >> Cc: Joel Becker <[email protected]> > > >> Cc: Casey Schaufler <[email protected]> > > >> Signed-off-by: Jie Liu <[email protected]> > > >> --- > > >> lib/kobject.c | 4 ++-- > > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > >> > > >> diff --git a/lib/kobject.c b/lib/kobject.c > > >> index 58751bb..538c617 100644 > > >> --- a/lib/kobject.c > > >> +++ b/lib/kobject.c > > >> @@ -919,11 +919,11 @@ struct kset *kset_create_and_add(const char *name, > > >> > > >> kset = kset_create(name, uevent_ops, parent_kobj); > > >> if (!kset) > > >> - return NULL; > > >> + return ERR_PTR(-ENOMEM); > > >> error = kset_register(kset); > > >> if (error) { > > >> kfree(kset); > > >> - return NULL; > > >> + return ERR_PTR(error); > > >> } > > >> return kset; > > >> } > > > > > > This patch series isn't bisectable. When changing an error signal from > > > NULL to non-NULL, you have to do it as one patch, otherwise if a > > > bisection lands in here we'll get error returns from all our kobject > > > kset code and the kernel won't boot. > > > > Thanks for pointing this out. > > > > > It's fine if you're sending it out as 24 patches for review, but it has > > > to be applied as a single one. > > > > Ok, I'll post the v2 patch as a single one once this series has been > > reviewed. > > Also, now that you sent a bunch of different patches out, some > maintainers will not realize that this first one has to be applied (i.e. > you gave them no sense that there was a dependancy.) > > You will have to watch very carefully to ensure that those patches do > not now get accepted, as they will break the existing code.
I've emailed a few responses to the patches that I could find, but please follow-up and email everyone to not apply the patches as responses to those patches so that everyone is properly notified. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
