Hi, On 06/12/2014 07:40 PM, [email protected] wrote: > From: Suravee Suthikulpanit <[email protected]> > > The current platform AHCI driver does not set the dma_mask correctly > for 64-bit DMA capable AHCI controller. This patch checks the AHCI > capability bit and set the dma_mask and coherent_dma_mask accordingly. > > Signed-off-by: Suravee Suthikulpanit <[email protected]> > Reviewed-by: Bartlomiej Zolnierkiewicz <[email protected]> > Reviewed-by: Hans de Goede <[email protected]>
I did not review this patch, just because you CC-ed me does not mean I've reviewed it. Please don't add my Reviewed-by unless you've gotten a mail from me saying something along these lines: This patch is: Reviewed-by: Hans de Goede <[email protected]> More in general please do not add any tags, other then Cc or your own Signed-off-by, unless you've actually received those tags in an email from people. Regards, Hans p.s. About the patch itself, I'll try to test this on sunxi devices to make sure that it does not break anything this weekend. > --- > drivers/ata/libahci_platform.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c > index 3a5b4ed..a958a2b 100644 > --- a/drivers/ata/libahci_platform.c > +++ b/drivers/ata/libahci_platform.c > @@ -364,6 +364,19 @@ int ahci_platform_init_host(struct platform_device *pdev, > ap->ops = &ata_dummy_port_ops; > } > > + if (hpriv->cap & HOST_CAP_64) { > + rc = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64)); > + if (rc) { > + rc = dma_coerce_mask_and_coherent(dev, > + DMA_BIT_MASK(32)); > + if (rc) { > + dev_err(dev, "Failed to enable 64-bit DMA.\n"); > + return rc; > + } > + dev_warn(dev, "Enable 32-bit DMA instead of 64-bit.\n"); > + } > + } > + > rc = ahci_reset_controller(host); > if (rc) > return rc; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
