On Mon, May 12, 2014 at 03:28:48PM +0900, Namhyung Kim wrote:
> The perf diff command itself doesn't make use of the --fields option,
> it still needs to call the function since the output only work with
> that way.
>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> tools/perf/builtin-diff.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index f3b10dcf6838..670d191bec31 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1155,6 +1155,9 @@ int cmd_diff(int argc, const char **argv, const char
> *prefix __maybe_unused)
> if (setup_sorting() < 0)
> usage_with_options(diff_usage, options);
>
> + if (setup_output_field() < 0)
> + usage_with_options(diff_usage, options);
> +
looks like this breaks perf diff even worse than it is now ;-)
[jolsa@krava perf]$ ./perf diff
# Event 'cycles'
#
# Baseline Delta
# ........ .......
#
28.03%
+18.93%
31.06%
+36.86%
35.06%
0.38%
0.03% +0.03%
+1.11%
5.44%
+43.05%
anyway, as I said it was already broken, I plan to check/fix this soon..
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
