From a3b36802a01f4b89a16c773c0645bf374969970a Mon Sep 17 00:00:00 2001 From: Oleg Drokin Date: Fri, 31 Jan 2014 15:34:05 -0500 Subject: [PATCH] vfs: Fix mountpoint reference leakage in linkat Recent changes to retry on ESTALE in linkat (commit 442e31ca5a49e398351b2954b51f578353fdf210) introduced a mountpoint reference leak and a small memory leak in case a filesystem link operation returns ESTALE which is pretty normal for distributed filesystems like lustre, nfs and so on. Free old_path in such a case. Also fix a similar leak in case of broken delegation. Signed-off-by: Oleg Drokin: --- fs/namei.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index bcb838e..cc3c6c4 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -3925,17 +3925,18 @@ retry: error = vfs_link(old_path.dentry, new_path.dentry->d_inode, new_dentry, &delegated_inode); out_dput: done_path_create(&new_path, new_dentry); +out: + path_put(&old_path); if (delegated_inode) { error = break_deleg_wait(&delegated_inode); - if (!error) + if (!error) { goto retry; + } } if (retry_estale(error, how)) { how |= LOOKUP_REVAL; goto retry; } -out: - path_put(&old_path); return error; } -- 1.8.5.3