On Sun, Jan 05, 2014 at 12:30:51PM -0800, Joe Perches wrote: > On Mon, 2014-01-06 at 01:41 +0530, MonamAgarwal wrote: > > This patch fixes the following checkpatch.pl warning in > > lustre/ldlm/interval_tree.c > > WARNING: line over 80 characters in the file > [] > > diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c > > b/drivers/staging/lustre/lustre/ldlm/interval_tree.c > [] > > @@ -429,7 +429,8 @@ static void interval_erase_color(struct interval_node > > *node, > > struct interval_node *o_left; > > o_left = tmp->in_left; > > if (o_left) > > - o_left->in_color = > > INTERVAL_BLACK; > > + o_left->in_color = > > + INTERVAL_BLACK; > > Likely this function would be better off with some > refactoring instead of straining to fit 80 cols.
I agree, if you are doing things like this, that's a huge hint that the code needs fixing. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
