Hi Masami, On Fri, 20 Dec 2013 10:02:57 +0000, Masami Hiramatsu wrote: > Expand given path to absolute path in option parser, > except for a module name. Instead of expanding it later, > this get the absolute path in early stage. > > Signed-off-by: Masami Hiramatsu <[email protected]> > --- > tools/perf/builtin-probe.c | 9 +++++++++ > tools/perf/util/probe-event.c | 11 ++--------- > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c > index 6ea9e85..b40d064 100644 > --- a/tools/perf/builtin-probe.c > +++ b/tools/perf/builtin-probe.c > @@ -180,6 +180,15 @@ static int opt_set_target(const struct option *opt, > const char *str, > else > return ret; > > + /* Expand given path to absolute path, except for modulename */ > + if (params.uprobes || strchr(str, '/')) { > + str = realpath(str, NULL); > + if (!str) { > + pr_warning("Failed to find the path of %s.\n", > + str);
It won't print the path since the str already was overwritten to NULL. > + return ret; > + } > + } > params.target = str; It now points either a dynamically allocated string or not.. Thanks, Namhyung > ret = 0; > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
