Commit-ID: 0058aef65eda9c9dde8253af702d542ba7eef697 Gitweb: http://git.kernel.org/tip/0058aef65eda9c9dde8253af702d542ba7eef697 Author: Adrian Hunter <[email protected]> AuthorDate: Tue, 3 Dec 2013 09:23:08 +0200 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 4 Dec 2013 13:46:36 -0300
perf symbols: Retain symbol source file name to lookup source line numbers Currently, lookup of an ip's source file name and line number is done using the dso file name. Instead retain the file name used to lookup the dso's symbols and use that. Signed-off-by: Adrian Hunter <[email protected]> Cc: Andi Kleen <[email protected]> Cc: David Ahern <[email protected]> Cc: Frederic Weisbecker <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Mike Galbraith <[email protected]> Cc: Namhyung Kim <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Stephane Eranian <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]> --- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 1 + tools/perf/util/srcline.c | 7 ++++++- tools/perf/util/symbol.c | 2 ++ 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 68aa55a..49da968 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -470,6 +470,7 @@ void dso__delete(struct dso *dso) free(dso->long_name); dso_cache__free(&dso->cache); dso__free_a2l(dso); + free(dso->symsrc_filename); free(dso); } diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h index d8613dc..7142e52 100644 --- a/tools/perf/util/dso.h +++ b/tools/perf/util/dso.h @@ -78,6 +78,7 @@ struct dso { struct rb_root symbol_names[MAP__NR_TYPES]; struct rb_root cache; void *a2l; + char *symsrc_filename; enum dso_kernel_type kernel; enum dso_swap_type needs_swap; enum dso_binary_type symtab_type; diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index 25b85b2..93795f9 100644 --- a/tools/perf/util/srcline.c +++ b/tools/perf/util/srcline.c @@ -249,11 +249,16 @@ char *get_srcline(struct dso *dso, unsigned long addr) char *file = NULL; unsigned line = 0; char *srcline; - char *dso_name = dso->long_name; + char *dso_name; if (!dso->has_srcline) return SRCLINE_UNKNOWN; + if (dso->symsrc_filename) + dso_name = dso->symsrc_filename; + else + dso_name = dso->long_name; + if (dso_name[0] == '[') goto out; diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 360eefe..de87dba 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c @@ -1336,6 +1336,8 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) if (!syms_ss && symsrc__has_symtab(ss)) { syms_ss = ss; next_slot = true; + if (!dso->symsrc_filename) + dso->symsrc_filename = strdup(name); } if (!runtime_ss && symsrc__possibly_runtime(ss)) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
