Commit-ID:  688b7585d16ab57a17aa4422a3b290b3a55fa679
Gitweb:     http://git.kernel.org/tip/688b7585d16ab57a17aa4422a3b290b3a55fa679
Author:     Mel Gorman <[email protected]>
AuthorDate: Mon, 7 Oct 2013 11:28:58 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 9 Oct 2013 12:40:23 +0200

sched/numa: Select a preferred node with the most numa hinting faults

This patch selects a preferred node for a task to run on based on the
NUMA hinting faults. This information is later used to migrate tasks
towards the node during balancing.

Signed-off-by: Mel Gorman <[email protected]>
Reviewed-by: Rik van Riel <[email protected]>
Cc: Andrea Arcangeli <[email protected]>
Cc: Johannes Weiner <[email protected]>
Cc: Srikar Dronamraju <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
 include/linux/sched.h |  1 +
 kernel/sched/core.c   |  1 +
 kernel/sched/fair.c   | 17 +++++++++++++++--
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index a810e95..b1fc75e 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1344,6 +1344,7 @@ struct task_struct {
        struct callback_head numa_work;
 
        unsigned long *numa_faults;
+       int numa_preferred_nid;
 #endif /* CONFIG_NUMA_BALANCING */
 
        struct rcu_head rcu;
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 6808d35..d15cd70 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1633,6 +1633,7 @@ static void __sched_fork(struct task_struct *p)
        p->numa_scan_seq = p->mm ? p->mm->numa_scan_seq : 0;
        p->numa_migrate_seq = p->mm ? p->mm->numa_scan_seq - 1 : 0;
        p->numa_scan_period = sysctl_numa_balancing_scan_delay;
+       p->numa_preferred_nid = -1;
        p->numa_work.next = &p->numa_work;
        p->numa_faults = NULL;
 #endif /* CONFIG_NUMA_BALANCING */
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0bb3e0a..9efd34f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -879,7 +879,8 @@ static unsigned int task_scan_max(struct task_struct *p)
 
 static void task_numa_placement(struct task_struct *p)
 {
-       int seq;
+       int seq, nid, max_nid = -1;
+       unsigned long max_faults = 0;
 
        if (!p->mm)     /* for example, ksmd faulting in a user's mm */
                return;
@@ -889,7 +890,19 @@ static void task_numa_placement(struct task_struct *p)
        p->numa_scan_seq = seq;
        p->numa_scan_period_max = task_scan_max(p);
 
-       /* FIXME: Scheduling placement policy hints go here */
+       /* Find the node with the highest number of faults */
+       for_each_online_node(nid) {
+               unsigned long faults = p->numa_faults[nid];
+               p->numa_faults[nid] >>= 1;
+               if (faults > max_faults) {
+                       max_faults = faults;
+                       max_nid = nid;
+               }
+       }
+
+       /* Update the tasks preferred node if necessary */
+       if (max_faults && max_nid != p->numa_preferred_nid)
+               p->numa_preferred_nid = max_nid;
 }
 
 /*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to