On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen <[email protected]> wrote: > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > need to include linux/sched.h
Really? <linux/sched.h> is the worst choice w.r.t. include hell. > This was done with a mechanistic script and some uses may be redundant > (already included in some other include file). However it's good practice > to always include any needed symbols from the top level .c file. > > Tested with x86-64 allyesconfig. I used to do a x86-32 allyesconfig > on a old kernel, but since that is broken now I didn't retest. > > Signed-off-by: Andi Kleen <[email protected]> > diff --git a/arch/mn10300/include/asm/uaccess.h > b/arch/mn10300/include/asm/uaccess.h > index 5372787..274c9c2 100644 > --- a/arch/mn10300/include/asm/uaccess.h > +++ b/arch/mn10300/include/asm/uaccess.h > @@ -14,6 +14,7 @@ > /* > * User space memory access functions > */ > +#include <linux/sched.h> > #include <linux/thread_info.h> > #include <linux/kernel.h> > #include <asm/page.h> This part breaks mn10300: CC init/version.o In file included from linux-next/include/linux/timex.h:56:0, from linux-next/include/linux/sched.h:17, from linux-next/arch/mn10300/include/asm/uaccess.h:17, from linux-next/arch/mn10300/include/asm/processor.h:21, from linux-next/include/linux/spinlock_up.h:8, from linux-next/include/linux/spinlock.h:89, from linux-next/include/linux/seqlock.h:29, from linux-next/include/linux/time.h:5, from linux-next/include/linux/stat.h:18, from linux-next/include/linux/module.h:10, from linux-next/init/version.c:10: linux-next/include/uapi/linux/timex.h:76:17: error: field 'time' has incomplete type http://kisskb.ellerman.id.au/kisskb/buildresult/9424440/ http://kisskb.ellerman.id.au/kisskb/buildresult/9424438/ Note that it doesn't use might_sleep(). It does use might_fault(), but only from a macro, not from a C inline function. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
