On 2013/8/5 16:54, Greg Kroah-Hartman wrote: > On Mon, Aug 05, 2013 at 04:31:00PM +0800, Xishi Qiu wrote: >> Use "PFN_DOWN(r->size)" instead of "r->size >> PAGE_SHIFT". >> >> Signed-off-by: Xishi Qiu <[email protected]> >> --- >> drivers/base/dma-contiguous.c | 5 ++--- >> 1 files changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c >> index 0ca5442..1bcfaed 100644 >> --- a/drivers/base/dma-contiguous.c >> +++ b/drivers/base/dma-contiguous.c >> @@ -201,13 +201,12 @@ static int __init cma_init_reserved_areas(void) >> { >> struct cma_reserved *r = cma_reserved; >> unsigned i = cma_reserved_count; >> + struct cma *cma; > > Why change this? > >> >> pr_debug("%s()\n", __func__); >> >> for (; i; --i, ++r) { >> - struct cma *cma; >> - cma = cma_create_area(PFN_DOWN(r->start), >> - r->size >> PAGE_SHIFT); >> + cma = cma_create_area(PFN_DOWN(r->start), PFN_DOWN(r->size)); > > That's reasonable to clean up, but nothing major. Care to resend this > without the cma change? >
Thank you and I will resend it soon. Thanks, Xishi Qiu > thanks, > > greg k-h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
