On Thursday 20 June 2013 02:07 PM, Kishon Vijay Abraham I wrote:
SMPS10 has two outputs OUT1 and OUT2 and have one input IN1.
SMPS10-OUT2 is connected to SMPS10-IN1 and can be configured either
in BOOST mode or BYPASS mode. regulator_enable of SMPS10-OUT2 configures
it in BOOST mode. For BYPASS mode regulator_allow_bypass() API can be
used. SMPS10-OUT1 is connected to SMPS10-OUT2 and can be enabled using
regulator_enable().

Cc: Laxman Dewangan <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
  drivers/regulator/palmas-regulator.c |   39 ++++++++++++++++++++++++++++++----
  include/linux/mfd/palmas.h           |    9 ++++----
  2 files changed, 40 insertions(+), 8 deletions(-)

diff --git a/drivers/regulator/palmas-regulator.c 
b/drivers/regulator/palmas-regulator.c
index 3ae44ac..7004bab 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -97,7 +97,12 @@ static const struct regs_info palmas_regs_info[] = {
                .ctrl_addr      = PALMAS_SMPS9_CTRL,
        },
        {
-               .name           = "SMPS10",
+               .name           = "SMPS10_OUT1",
+               .sname          = "smps10-out2",
+               .ctrl_addr      = PALMAS_SMPS10_CTRL,
+       },
+       {
+               .name           = "SMPS10_OUT2",
                .sname          = "smps10-in",


This sequence can create regulator to be never register.
In probe, we register regulator from 0 to max_id.
Here smps10-out1 comes first and see the supply as smps10-out2 which is not registered yet and so will fail with PROBE_DEFER
When again it tries, the same issue.

I think we need to reverse the sequence, SMPS10-OUT2 and then SMPS10-OUT1.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to