On 6/14/2013 3:05 PM, Philip Avinash wrote: > Make some minor coding style fixes. Use proper multi-line > commenting style, arrange include files alphabetically use > macros for bit definitions.
Its a register offset, not bit definition. > > Signed-off-by: Philip Avinash <[email protected]> > Signed-off-by: Sekhar Nori <[email protected]> > --- > Changes since v1: > - Remove variable name replacement > - Add line break after BINTEN macro definition > > drivers/gpio/gpio-davinci.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c > index 17df6db..e8d189c 100644 > --- a/drivers/gpio/gpio-davinci.c > +++ b/drivers/gpio/gpio-davinci.c > @@ -9,12 +9,12 @@ > * the Free Software Foundation; either version 2 of the License, or > * (at your option) any later version. > */ > -#include <linux/gpio.h> > -#include <linux/errno.h> > -#include <linux/kernel.h> > + This is unnecessary empty line. I made these fixes locally and added this to my v3.11/gpio branch. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
