On Tue, Jun 18, 2013 at 11:59:44AM +0200, Jonas Jensen wrote:
> +void moxart_irq_ack(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> +
> + writel(1 << irq, IRQ_CLEAR(moxart_irq_base));
> +}
> +
> +static void moxart_irq_mask(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> + unsigned int mask;
> +
> + mask = readl(IRQ_MASK(moxart_irq_base));
> + mask &= ~(1 << irq);
> + writel(mask, IRQ_MASK(moxart_irq_base));
> +}
> +
> +static void moxart_irq_unmask(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> + unsigned int mask;
> +
> + mask = readl(IRQ_MASK(moxart_irq_base));
> + mask |= (1 << irq);
> + writel(mask, IRQ_MASK(moxart_irq_base));
> +}
Is there a reason this isn't using the irq_chip_generic stuff which would
eliminate all the above?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
