On Sat, 9 Mar 2013 19:16:46 +0100, Lars-Peter Clausen wrote: > i2c_del_adapter() always returns 0. So all checks testing whether it will be > non zero will always evaluate to false and the conditional code is dead code. > This patch updates all callers of i2c_del_mux_adapter() to ignore the return > value and assume that it will always succeed (which it will). In a subsequent > patch the return type of i2c_del_adapter() will be made void. > > Cc: Jean Delvare <[email protected]> > Cc: Guan Xuetao <[email protected]> > Cc: Mauro Carvalho Chehab <[email protected]> > Cc: Ben Hutchings <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Alan Cox <[email protected]> > Cc: Nicolas Ferre <[email protected]> > Cc: Aaro Koskinen <[email protected]> > Cc: Marek Vasut <[email protected]> (commit_signer:11/20=55%) > Cc: Shawn Guo <[email protected]> > Cc: Benjamin Herrenschmidt <[email protected]> > Cc: Lars Poeschel <[email protected]> > Signed-off-by: Lars-Peter Clausen <[email protected]> > --- > drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 3 +-- > drivers/i2c/busses/i2c-amd756-s4882.c | 6 +----- > drivers/i2c/busses/i2c-at91.c | 5 ++--- > drivers/i2c/busses/i2c-cbus-gpio.c | 4 +++- > drivers/i2c/busses/i2c-intel-mid.c | 3 +-- > drivers/i2c/busses/i2c-mv64xxx.c | 5 ++--- > drivers/i2c/busses/i2c-mxs.c | 5 +---- > drivers/i2c/busses/i2c-nforce2-s4985.c | 6 +----- > drivers/i2c/busses/i2c-powermac.c | 10 ++-------- > drivers/i2c/busses/i2c-puv3.c | 10 ++-------- > drivers/i2c/busses/i2c-viperboard.c | 5 ++--- > drivers/i2c/i2c-mux.c | 5 +---- > drivers/media/pci/bt8xx/bttv-input.c | 6 +++--- > drivers/media/pci/mantis/mantis_i2c.c | 4 +++- > drivers/net/ethernet/sfc/falcon.c | 6 ++---- > drivers/staging/media/go7007/go7007-driver.c | 7 ++----- > 16 files changed, 29 insertions(+), 61 deletions(-) > (...)
For i2c-amd756-s4882, i2c-nforce2-s4985 and i2c-mux: Reviewed-by: Jean Delvare <[email protected]> -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
