On Tue, 12 Mar 2013 18:52:54 -0300 Lucas De Marchi <[email protected]> wrote:
> On Tue, Mar 12, 2013 at 5:31 PM, Andrew Morton > <[email protected]> wrote: > > On Mon, 11 Mar 2013 21:48:06 -0300 Lucas De Marchi > > <[email protected]> wrote: > > > >> call_usermodehelper_setup() + call_usermodehelper_exec() need to be > >> called instead of call_usermodehelper_fns() when the cleanup function > >> needs to be called even when an ENOMEM error occurs. In this case using > >> call_usermodehelper_fns() the user can't distinguish if the cleanup > >> function was called or not. > > > > call_usermodehelper_exec() was exported to modules but > > call_usermodehelper_setup() was not? > > > > That was a mistake. We need both functions exported. Should I send and > updated patch or a fixup? From: Andrew Morton <[email protected]> Subject: usermodehelper-export-_exec-and-_setup-functions-fix export call_usermodehelper_setup() to modules Cc: "Rafael J. Wysocki" <[email protected]> Cc: Al Viro <[email protected]> Cc: David Howells <[email protected]> Cc: James Morris <[email protected]> Cc: Lucas De Marchi <[email protected]> Cc: Oleg Nesterov <[email protected]> Cc: Tejun Heo <[email protected]> Signed-off-by: Andrew Morton <[email protected]> --- kernel/kmod.c | 1 + 1 file changed, 1 insertion(+) diff -puN kernel/kmod.c~usermodehelper-export-_exec-and-_setup-functions-fix kernel/kmod.c --- a/kernel/kmod.c~usermodehelper-export-_exec-and-_setup-functions-fix +++ a/kernel/kmod.c @@ -541,6 +541,7 @@ struct subprocess_info *call_usermodehel out: return sub_info; } +EXPORT_SYMBOL(call_usermodehelper_setup); /** * call_usermodehelper_exec - start a usermode application _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
