(2013/03/12 17:21), Ingo Molnar wrote: > > * Masami Hiramatsu <[email protected]> wrote: > >> @@ -31,7 +32,7 @@ >> #error Wordsize not 32 or 64 >> #endif >> >> -static inline u64 hash_64(u64 val, unsigned int bits) >> +static __kprobes inline u64 hash_64(u64 val, unsigned int bits) >> { >> u64 hash = val; > > We should also, really, really fix the '__kprobes' misnomer and switch to > the '__noprobe' pattern or so. The naming does not make it obvious at all > that what we do here is to turn _off_ kprobing of select functions...
Agreed. > The only complication is that __kprobes is now present in 600+ places, > which will create merge conflicts. If you remind me during the next merge > window I can generate the rename on the spot and send it to Linus without > anyone having to carry the patch for too long. Let me confirm that I just move __kprobes definition into compiler.h this time, and ping you when the next merge window opens, is that correct? Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
