On Friday 22 February 2013 01:06 AM, Tejun Heo wrote: > On Fri, Feb 22, 2013 at 01:03:41AM +0530, Vineet Gupta wrote: >> Where - you mean if user passes 0, just make it 1. Nah - it's better to >> complain >> and get the call site fixed ! >> >>> or BUG_ON(!align) instead? >> That could be done too but you would also need BUG_ON(!size) - to catch >> another >> API abuse. >> BUG_ON(!size) however catches both the cases. > How about "if (WARN_ON(!align)) align = __alignof__(long long);"? > Early BUG_ON()s can be painful to debug depending on setup.
Totally agree - been there - seen that :-) Also for caller passing zero, the panic will force the caller to fix it. I'll respin the patch. Thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
