Hi Arnaldo, 2013-01-11 (금), 02:17 -0300, Arnaldo Carvalho de Melo: > Em Thu, Dec 27, 2012 at 06:11:44PM +0900, Namhyung Kim escreveu: > > From: Namhyung Kim <[email protected]> > > > > When setup_sorting() is called, 'str' is passed to strtok_r() but it's > > not checked to have a valid pointer. As strtok_r() accepts NULL > > pointer on a first argument and use the third argument in that case, > > it can cause a trouble since our third argument, tmp, is not > > initialized. > > Ok, but calling exit from here? Better to check it at the callers and > propagate the error, letting things like TUI/gui exit routines to > execute.
That's fine to me too, but currently setup_sorting() exits through usage_with_options() if sort_dimension__add() fails and I followed the convention here. Making it to return will require changes to every callsites of the function. If you think it's better to change, I can do it as well. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
