On Thu, Nov 15, 2012 at 03:27:42PM +0530, Srinidhi Kasagar wrote:
> On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
> >
> > > > - if (timeout < 0) {
> > > > - dev_err(&dev->adev->dev,
> > > > - "wait_for_completion_timeout "
> > > > - "returned %d waiting for event\n", timeout);
> > > > - status = timeout;
> > > > - }
> > > > -
> > > No, it is wrong. You need to update the status variable in the case of
> > > timeout.
> >
> > Looking at the patch context, such code comes later.
> But it causes regressions; without looking at the "later" code, we can't
> afford merging
> this code now.Later as in "a few lines later" not "some time later". Or am I missing something else? -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
