On Thu, Aug 30, 2012 at 10:45:56AM -0700, Dan Carpenter wrote: > On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote: > > acpi_os_map_memory expects its return value to be in the __iomem address > > space. Cast it back later when used in a memcpy to avoid the same sparse > > warning there. > > > > Signed-off-by: Kent Yoder <[email protected]> > > I can't download linux-next right now but I don't think this is the > correct fix. I don't think you can memcpy() directly from __iomem. > The static checker is warning about a valid bug which should be > addressed instead of just casted away and silenced.
I took a look at other uses of the return from acpi_os_map_memory(), such as acpi_tb_parse_fadt(), which passes the returned pointer to acpi_tb_create_local_fadt(), which uses ACPI_MEMCPY on it, which is just memcpy. This code lives in drivers/acpi. Kent > > regards, > dan carpenter > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
