> > Also, a logic of erase callback is freshly created instead of sharing
> > with a write callback because the sysfs operation is kicked in just oops
> > case in a write callback and an erase callback doesn't work
> without any change.
> > By separating a logic to a write callback, an erase callback works
> > correctly.
>
> I don't understand why this part of the patch is required.
If I have to keep sharing the code of an erase callback with a write callback,
I can change my patch as follows.
I just thought the code would be ieasy to read by separating them.
<snip>
efi_pstore_write()
{
+ /*
+ * The user may want to update when they erases an entry or see it for
this write in sysfs in oops case.
+ */
+ if (!size || reason == KMSG_DUMP_OOPS)
+ schedule_work(&efivar_work);
}
<snip>
Seiji
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
