On Mon, Aug 6, 2012 at 5:50 PM, Linus Walleij <[email protected]> wrote: > On Mon, Aug 6, 2012 at 5:46 PM, Axel Lin <[email protected]> wrote: >> 2012/7/4 Mark Brown <[email protected]>: >>> On Wed, Jul 04, 2012 at 10:31:45AM +0800, Axel Lin wrote: >>>> Signed-off-by: Axel Lin <[email protected]> >>>> --- >>>> Hi Linus, >>>> While working on this patch, I found in original code: >>>> ab8500_regulator_ops set enable_time callback to >>>> ab8500_regulator_enable_time, >>>> but does not set the delay in ab8500_regulator_info. >>>> I'm not sure the delay value is 0 for ab8500_regulator_ops, or the setting >>>> is >>>> just missing. >>>> Anyway, there is no behavior change by this patch. >>> >>> Surely if the delay is not set in info then it'll introduce a delay >>> which wasn't there before (but which may well be a bug fix)? >> >> Ping... >> >> Hi Linus, >> Any comments on this patch? > > Looks good to me: > Acked-by: Linus Walleij <[email protected]> > > I need to check the proper rise times with the maintainers.
I remember this now. Only that one regulator has a non-negligeble rise time, so for that reason it's set to that value. Atleast so I was told once upon a time when I implemented it, so this patch should be fine. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
