On Fri, 2008-02-15 at 11:23 +0100, Miklos Szeredi wrote: > This is for 2.6.25 and 2.6.24.y, but NOT for 2.6.23.y. > > Thanks, > Miklos > ---- > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > I added a nasty local variable shadowing bug to fuse in 2.6.24, with > the result, that the 'default_permissions' mount option is basically > ignored. > > How did this happen? > > - old err declaration in inner scope > - new err getting declared in outer scope > - 'return err' from inner scope getting removed > - old declaration not being noticed > > -Wshadow would have saved us, but it doesn't seem practical for > the kernel :( > > More testing would have also saved us :((
sparse would have saved you too. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
