On Sun, Oct 11, 2026 at 06:33:40PM -0400, Sasha Levin wrote:
> rte_smp_mb() has never been used, and its "static inline __always_inline"
> declares inline twice, so clang warns:
>
> vmbus_bufring.c:61:15: warning: duplicate 'inline' declaration specifier
> [-Wduplicate-decl-specifier]
> vmbus_bufring.c:62:1: warning: unused function 'rte_smp_mb'
> [-Wunused-function]
>
> Remove it.
>
> Fixes: 45bab4d746510 ("tools: hv: Add vmbus_bufring")
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <[email protected]>
Reviewed-by: Hamza Mahfooz <[email protected]>
> ---
> tools/hv/vmbus_bufring.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tools/hv/vmbus_bufring.c b/tools/hv/vmbus_bufring.c
> index bac32c1109df8..23542e59a2ee9 100644
> --- a/tools/hv/vmbus_bufring.c
> +++ b/tools/hv/vmbus_bufring.c
> @@ -58,12 +58,6 @@ void vmbus_br_setup(struct vmbus_br *br, void *buf,
> unsigned int blen)
> br->dsize = blen - sizeof(struct vmbus_bufring);
> }
>
> -static inline __always_inline void
> -rte_smp_mb(void)
> -{
> - asm volatile("lock addl $0, -128(%%rsp); " ::: "memory");
> -}
> -
> static inline int
> rte_atomic32_cmpset(volatile uint32_t *dst, uint32_t exp, uint32_t src)
> {
> --
> 2.53.0
>
