Re: [PATCH] selftests: memcg: don't close an uninitialized fd

[T.J. Mercier]

On Sun, Oct 11, 2026 at 3:34 PM Sasha Levin <sas...@kernel.org> wrote:
>
> test_memcg_inotify_delete_file() and test_memcg_inotify_delete_dir()
> jump to cleanup before the inotify fd is created when cg_name() or
> cg_create() fails, and cleanup then closes whatever fd holds:
>
>   test_memcontrol.c:1685:6: warning: variable 'fd' is used uninitialized 
> whenever 'if' condition is true [-Wsometimes-uninitialized]
>
> Initialize fd to -1.
>
> Fixes: 2de27980e1d46 ("selftests: memcg: Add tests for IN_DELETE_SELF and 
> IN_IGNORED")
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sas...@kernel.org>

Reviewed-by: T.J. Mercier <tjmerc...@google.com>