On 23/09/2026 12:43, Sebastian Andrzej Siewior wrote: > Wouldn't it be simpler to not allow such packets?
For master TX, yes: removing GSO features lets the core segment before ndo_start_xmit(), as patch 3 already does. The interlink RX path is different. With GRO/GRO_HW disabled, it can still receive skbs that were already GSO at the sender. I reproduced this with ordinary TCP traffic over veth in a VM. Rejecting these skbs would drop valid traffic. I'll retain segmentation for valid interlink GSO in the ordered consumer described in my patch 2 reply, before per-frame sequence allocation and HSR tag/PRP RCT construction. Each aggregate would finish before the next input, without holding an HSR lock across segmentation or transmission. -- Xin
