On 9/20/26 2:39 PM, Uwe Kleine-König wrote:
Hello Alex,
On Fri, Sep 18, 2026 at 11:52:32AM -0500, Alex Elder wrote:
+#include <linux/bits.h>
+#include <linux/clk-provider.h>
+#include <linux/mfd/syscon.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reset-controller.h>
Please rely on linux/platform_device.h to provide of_device_id and drop
including <linux/mod_devicetable.h>. (If you want to go full iwyu,
include <linux/device-id/of.h> instead.)
In general I would like to "go full iwyu" but have never heard
it expressed that way. Can you recommend a tool available that
will help me do that?
It looks like "mod_devicetable.h" doesn't help much unless I
need struct_cpu_feature (which I do not), so I'll include "of.h".
+static const struct of_device_id tc9564_clk_ids[] = {
+ { .compatible = "toshiba,tc9564-clock" },
+ { },
+};
Drop the trailing comma after the list terminator please.
OK. Only for the list terminator, right, because nothing
will ever follow it? Non-empty final initializer is OK
to have a comma as far as you're concerned?
Thanks for your review.
-Alex
Best regards
Uwe
