On 9/15/26 00:32, Kees Cook wrote: > Using default_gfp() only depends on the GFP_KERNEL value. Move > default_gfp() into gfp_types.h so that future use in devres.h doesn't > require pulling in all of gfp.h. > > Signed-off-by: Kees Cook <[email protected]>
Reviewed-by: Vlastimil Babka (SUSE) <[email protected]> Incidentally I was thinking if default_gfp(...) usage should be extended also for the legacy kmalloc() API. Because it's going to still have users, buffers are needed for many things that are not objects (structs). Mike is converting many unnecessary page allocator usages to kmalloc(PAGE_SIZE, ...) often with GFP_KERNEL, so that would be neater too... > --- > Cc: Lorenzo Stoakes <[email protected]> > Cc: Andrew Morton <[email protected]> > Cc: David Hildenbrand <[email protected]> > Cc: "Liam R. Howlett" <[email protected]> > Cc: Vlastimil Babka <[email protected]> > Cc: Mike Rapoport <[email protected]> > Cc: Suren Baghdasaryan <[email protected]> > Cc: Michal Hocko <[email protected]> > Cc: Brendan Jackman <[email protected]> > Cc: Johannes Weiner <[email protected]> > Cc: Zi Yan <[email protected]> > Cc: <[email protected]> > --- > include/linux/gfp.h | 4 ---- > include/linux/gfp_types.h | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 872bc53f32ec..b62e2fd53cb4 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -13,10 +13,6 @@ > struct vm_area_struct; > struct mempolicy; > > -/* Helper macro to avoid gfp flags if they are the default one */ > -#define __default_gfp(a,b,...) b > -#define default_gfp(...) __default_gfp(,##__VA_ARGS__,GFP_KERNEL) > - > static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags) > { > return !!(gfp_flags & __GFP_DIRECT_RECLAIM); > diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h > index 190191411009..b1cd143f3c42 100644 > --- a/include/linux/gfp_types.h > +++ b/include/linux/gfp_types.h > @@ -382,4 +382,8 @@ enum { > __GFP_NOMEMALLOC | __GFP_NOWARN) & ~__GFP_RECLAIM) > #define GFP_TRANSHUGE (GFP_TRANSHUGE_LIGHT | __GFP_DIRECT_RECLAIM) > > +/* Helper macro to avoid gfp flags if they are the default one */ > +#define __default_gfp(a,b,...) b > +#define default_gfp(...) __default_gfp(,##__VA_ARGS__,GFP_KERNEL) > + > #endif /* __LINUX_GFP_TYPES_H */
