On Sat Sep 12, 2026 at 4:29 PM EDT, Jaeyeon Lee wrote: > The XFS setup for ./khugepaged all:file checks that the kernel supports > XFS but not that mkfs.xfs is installed. When CONFIG_XFS_FS=y and > xfsprogs is missing, mkfs.xfs and mount both fail, but > SPLIT_HUGE_PAGE_TEST_XFS_PATH is assigned from mktemp -d and stays set. > The test then runs against plain tmpfs and six subtests fail. > > The script already has a skip path for this test, but it never runs > because the path variable is always set. Assign > SPLIT_HUGE_PAGE_TEST_XFS_PATH only once mkfs.xfs and mount have both > succeeded, and remove the image and directory otherwise. > > Suggested-by: Zi Yan <[email protected]> > Assisted-by: LLM > Signed-off-by: Jaeyeon Lee <[email protected]> > --- > Changes in v2: > - Attempt mkfs.xfs and mount and fall back if either fails, rather than > only checking whether mkfs.xfs exists (Zi Yan) > - Fix Assisted-by tag format > > v1: > https://lore.kernel.org/linux-mm/[email protected]/ > > tools/testing/selftests/mm/run_vmtests.sh | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) >
LGTM. Thanks. Reviewed-by: Zi Yan <[email protected]> -- Best Regards, Yan, Zi
