> On 9/11/26 14:50, Yeoreum Yun wrote: > > Since commit 0389c305ef56 (“selftests/mm: skip soft-dirty tests when > > CONFIG_MEM_SOFT_DIRTY is disabled”), > > the soft-dirty test is skipped when soft-dirty is not supported. > > > > There is therefore no reason to exclude the test from being built on > > arm64. Remove the arm64-specific exclusion. > > > > Suggested-by: David Hildenbrand (Arm) <[email protected]> > > Signed-off-by: Yeoreum Yun <[email protected]> > > --- > > tools/testing/selftests/mm/Makefile | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/Makefile > > b/tools/testing/selftests/mm/Makefile > > index 2d5366196e30..d3e9bd67904a 100644 > > --- a/tools/testing/selftests/mm/Makefile > > +++ b/tools/testing/selftests/mm/Makefile > > @@ -104,10 +104,7 @@ TEST_GEN_FILES += guard-regions > > TEST_GEN_FILES += merge > > TEST_GEN_FILES += rmap > > TEST_GEN_FILES += folio_split_race_test > > - > > -ifneq ($(ARCH),arm64) > > TEST_GEN_FILES += soft-dirty > > -endif > > > > ifeq ($(ARCH),x86_64) > > CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh "$(CC)" > > ../x86/trivial_32bit_program.c -m32) > > Does that mean we can also the following? > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh > b/tools/testing/selftests/mm/run_vmtests.sh > index d09f9f6a384ee..33963535616b2 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -390,10 +390,7 @@ then > CATEGORY="pkey" run_test ./protection_keys_64 > fi > > -if [ -x ./soft-dirty ] > -then > - CATEGORY="soft_dirty" run_test ./soft-dirty > -fi > +CATEGORY="soft_dirty" run_test ./soft-dirty > > CATEGORY="pagemap" run_test ./pagemap_ioctl
Ah right. since all archs have the soft-dirty, we can remove the if condition. Thanks! -- Sincerely, Yeoreum Yun
