> diff --git a/tools/testing/selftests/bpf/prog_tests/sock_destroy.c 
> b/tools/testing/selftests/bpf/prog_tests/sock_destroy.c
> index 9c11938fe597d..b90fab7073386 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sock_destroy.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sock_destroy.c

[ ... ]

> @@ -204,11 +272,12 @@ void test_sock_destroy(void)
>               test_tcp_client(skel);
>       if (test__start_subtest("tcp_server"))
>               test_tcp_server(skel);
> +     if (test__start_subtest("tcp_timewait"))
> +             test_tcp_timewait(skel);
>       if (test__start_subtest("udp_client"))
>               test_udp_client(skel);
>       if (test__start_subtest("udp_server"))
>               test_udp_server(skel);
> -
>       RUN_TESTS(sock_destroy_prog_fail);

This isn't a bug, but was dropping the blank line before RUN_TESTS()
intended as part of this change? The deleted line had been separating the
block of test__start_subtest() calls from RUN_TESTS(), which is a
different kind of step. If the grouping was intentional, could that line
stay so the diff is limited to registering the new subtest?

[ ... ]


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/33861180631

Reply via email to