On Tue, 2026-09-01 at 17:02 -0700, Kees Cook wrote:

> Thanks for getting the working on sparc! :)
> 
Thank you for the quick and friendly review! This is my first feature
submission to the kernel. I've only sent some bug fixes earlier, so
that's much appreciated. 
> 
> Is struct sparc64_user_regs not exported to userspace anywhere? We
> haven't normally needed to put the raw user_regs struct definition
> into
> the test before.
> 
Good point. 

Sparc has its own PTRACE_GETREGS64/PTRACE_SETREGS64 requests that
transfer the uapi struct pt_regs directly from <asm/ptrace.h>, so thel
ocal definition wasn't needed after all.

One small quirk I hit though. The requests use the historical layout
that omits %g0, so the transferred block starts at %g1 and every u_regs
index is one lower than the register number suggests (%g1 is u_regs[0],
%o0 is u_regs[7]). 

Will post v2 with a comment saying so now. Re-ran the suite on
the T4-1 with the new version: still 95 of 95.


-- 
Best regards
Stian Halseth

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to