On 8/31/26 9:55 AM, Alexis Lothoré wrote:
On Fri Aug 28, 2026 at 8:10 AM CEST, Bochao Cao wrote:
Thanks Daniel and Alexis.
Dropping the procps dependency is not the primary motivation for
this change. I agree that Debian can remove the dependency independently.
The issue addressed by this patch is process isolation in the standalone
test. The current readiness check may observe an unrelated
concurrent xdp_features process, while cleanup may terminate every
xdp_features
process on the host. In addition, a DUT which exits before listening can
leave the test waiting indefinitely.
Although this script is not currently run by the BPF CI, it remains
useful for testing real hardware,
so these process lifecycle issues can still affect users running the
test manually.
Would it be acceptable to fix these issues in the script's current
location?
If the preferred direction is to move it under
tools/testing/selftests/drivers/net/hw/,
should the move be submitted first, with this fix rebased on top?
I have no strong feeling about whether it should be moved or kept here,
I'll let BPF/netdev maintainers express their opinions here (Jakub
already suggested in [1] that there are helpers in net testing helpers
that could help making it move to the net tests). I've added Lorenzo in
CC, who is the original author of the script.
Given it is explicitly for testing real HW/driver capabilities wrt XDP,
it would make sense to me to migrate it over into
tools/testing/selftests/drivers/net/hw/ ; then vendors can run it also as
part of their netdev CI.
Thanks,
Daniel
Alexis
[1] https://lore.kernel.org/bpf/[email protected]/
