I checked the sashiko's comment: https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
> Should this new UAPI attribute also be added to the Netlink YAML > specification? > Is this new attribute missing from the netlink YAML > specification? > should this new attribute be documented in > Documentation/netlink/specs/rt-route.yaml > Is the del-reason (RTA_DEL_REASON) attribute missing from the YAML > specification? > Is there a missing patch in this series to actually report the > deletion reason? > Does this del_reason actually get passed from the deletion path? These are answered by later patches in the same series. > This is a pre-existing issue, but could this RTM_NEWROUTE be emitted > out of order with respect to an RTM_DELROUTE? Not related to the current series but might be worth sending a follow up separately. > Should this new enum and its entries include doc properties to > describe the specific deletion reasons for the uAPI documentation? Agreed, but it is a nit. If I need to send out patch series 6 due to adjusting later review comments, I will include the fix for this comment as well. > Is RTA_DEL_REASON missing from rtm_ipv6_policy and rtm_ipv4_policy? > [...] Should it be added to the policies as NLA_IGNORE or > NLA_REJECT? > Will the new RTA_DEL_REASON attribute be rejected if user space > echoes it back? [...] causing an ABI breakage. The comment seems wrong. The attribute is kernel to user space notification-only, user space code should never set it. Thanks, Yuyang
