On 7/29/26 8:45 AM, Minxi Hou wrote: > Add OVS_KEY_ATTR_SCTP to the ovskey parse table in ovs-dpctl.py so > that SCTP flow strings carry the L4 key through to the kernel, and > add a matching selftest in openvswitch.sh. > > The missing parse-table entry caused a selftest NIPA failure: the > flow string "sctp(dst=4443)" parsed without error but silently > dropped the L4 key, producing a flow with only ipv4(proto=132). > The kernel's match_validate() then rejected it with -EINVAL because > OVS_KEY_ATTR_SCTP was missing for IPPROTO_SCTP. > > Changes from v6: > - Trim unit tests to cover only the new SCTP key parser > (removed tests for TCP/UDP/ICMP/IPv4/EthType which were out of > scope for this patch); address Aaron's feedback that testing > existing parsers was excessive for a selftest tool.
I think, what Aaron meant is that we don't need tests for the test code in general, not only for existing parsers. And I agree that it feels a little excessive. I'd suggest dropping the unit tests and merge patches back into one. Also, you need to update the tools/testing/selftests/net/openvswitch/config to include SCTP, as it is not enabled at the moment. Aaron will do a more technical review of the test, so please wait for his reply before sending v8. Best regards, Ilya Maximets.
