Hello Markus, On Mon, Jun 01, 2026 at 09:02:04AM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) > to consider: > - [High] Moving `wkup_r5fss0_core0_memory_region` to the shared > `k3-am62p-ti-ipc-firmware.dtsi` silently truncates the reserved memory size > for Verdin boards from 30MB to 15MB. > - [Medium] Moving `wkup_r5fss0_core0_memory_region` to the shared > `k3-am62p-ti-ipc-firmware.dtsi` causes fatal `dtc` duplicate label errors and > overlapping reserved memory regions for Var-SOM boards. > -- > > commit 65cd200377411c4597f1b662700915ea23cfe5f8 > Author: Markus Schneider-Pargmann (TI) <[email protected]> > > arm64: dts: ti: k3-am62p-ti-ipc-firmware: Move wkup reserved memory > > The commit moves the wkup_r5fss0_core0 memory regions to a common > k3-am62p-ti-ipc-firmware.dtsi file to combine identical definitions > across boards. > > > Move the reserved memory regions used for wkup_r5fss0_core0 to the > > k3-am62p-ti-ipc-firmware.dtsi. These are all the same for the other > > boards as well, so we can combine them here similar to what is already > > done for the mcu_r5fss0_core0 memory regions. > > [Severity: High] > Are these regions exactly the same for all other boards? > > k3-am62p-verdin.dtsi explicitly defines the wkup_r5fss0_core0_memory_region > with a size of 30MB (0x01e00000): > > wkup_r5fss0_core0_memory_region: memory@9c900000 { > compatible = "shared-dma-pool"; > reg = <0x00 0x9c900000 0x00 0x01e00000>; > no-map; > }; > > Because k3-am62p-verdin.dtsi includes k3-am62p-ti-ipc-firmware.dtsi at the > very end of the file, dtc cleanly merges the identically-named node paths, and > the new generic definition silently overrides the board-specific 30MB size > down to 15MB. > > Does this halving of the available memory for IPC on Verdin boards cause > firmware load failures or runtime out-of-memory crashes on the R5 core? > > (Note: A subsequent patch in the series 'arm64: dts: ti: > k3-am62p-ti-ipc-firmware: Split r5f memory region' changes the label and size > to 1MB, which further truncates the region without fixing the underlying > overwrite.)
Can you have a look on this? There is no specific reason for Verdin AM62P deviating from the TI SK board on this memory size topic, we should avoid duplication and silently overriding those however. Francesco
